Fix radio, checkbox and select #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw, I tried to update to the newest version of |
afontcu
force-pushed
the
fix-radio-checkbox
branch
from
35c4fdb to
a50ec54
Compare
dfcook
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK,
checkboxandradioelements use acheckedproperty to express that they've been selected, which is set totrue. So there's no need to pass avalueargument.Same thing with
<option>elements. There was an issue withthis(due to copy&paste, I guess! 😇), so I also improved naming a bit.I also improved tests a bit, to demonstrate that the updated element in each case is properly being checked.